[PATCH] D47441: SafepointIRVerifier should ignore dead blocks and dead edges

[Anna Thomas via Phabricator via llvm-commits]

anna added a comment.

Hi Yevgeny, this looks close to commit. Comments inline.



================
Comment at: lib/IR/CFGDeadness.cpp:127
+      const Use &U = PU.getUser()->getOperandUse(PU.getOperandNo());
+      assert(!result &&
+             "Phi is not expected to refer to one block several times");
----------------
I think the assert and the corresponding ifdef compilation with break isn't very useful. It's just testing a property of the IRVerifier for phi nodes. 
Also, conditional compilation with behaviour change is not very preferable. Could we get rid of this?


================
Comment at: lib/IR/CFGDeadness.cpp:160
+INITIALIZE_PASS_BEGIN(CFGDeadnessWrapperPass, "cfgdeadness",
+                      "CFG Deadness", true, true)
+INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
----------------
it doesn't modify CFG, so the cfg arg should be false.  


================
Comment at: lib/IR/CFGDeadness.cpp:163
+INITIALIZE_PASS_END(CFGDeadnessWrapperPass, "cfgdeadness",
+                      "CFG Deadness", true, true)
+
----------------
ditto here.


https://reviews.llvm.org/D47441