[PATCH] D46653: Start support for linking object files with split stacks
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 5 11:44:38 PDT 2018
pcc added inline comments.
================
Comment at: ELF/Arch/X86_64.cpp:481
+ }
+ // Adjust "lea -0x200(%rsp),%r10" to lea "-0x4200(%rsp),%r10"
+ const uint8_t P1[] = {0x44, 0x8d, 0x94, 0x24, 0x00, 0xf2, 0xff};
----------------
ruiu wrote:
> Style issue: put a blank line before comment.
I think this should say `%r10d`, not `%r10`. Similarly `%r11d` below.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D46653
More information about the llvm-commits
mailing list