[PATCH] D47791: Initial support for Hexagon target.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/Hexagon.cpp:46
+
+  for (size_t Bit = 0; Bit != sizeof(uint32_t) * 8; ++Bit) {
+    const bool ValBit = (Data >> Off) & 1;
----------------
sizeof(uint32_t) * 8 is always 32.


================
Comment at: ELF/Arch/Hexagon.cpp:77
+  }
+
+  default:
----------------
Remove extraneous blank line. If you take a look at other files in lld, you'd notice that we normally don't add a blank line before "default:".


================
Comment at: test/ELF/Inputs/hexagon.s:1
+
+.global _start
----------------
Remove a leading empty line.


================
Comment at: test/ELF/hexagon.s:2
+# REQUIRES: hexagon
+# RUN: llvm-mc  -filetype=obj -triple=hexagon-unknown-elf %s -o %t
+# RUN: llvm-mc  -filetype=obj -triple=hexagon-unknown-elf %S/Inputs/hexagon.s -o %t2
----------------
Remove extranesous space between "mc" and "-filetype"


================
Comment at: test/ELF/hexagon.s:9
+call #_start
+# CHECK:    call 0x11000
----------------
Remove extraneous space characters.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47791