[PATCH] D47783: [MS][ARM64]: Add AArch64_WindowsTargetObjectFile and implement AArch64_WindowsTargetObjectFile::lowerRelativeReference

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lib/Target/AArch64/AArch64TargetObjectFile.cpp:82
+
+const MCExpr *AArch64_WindowsTargetObjectFile::lowerRelativeReference(
+    const GlobalValue *LHS, const GlobalValue *RHS,
----------------
Rather than duplicate this, I think we should hoist `__ImageBase` handling into `TargetLoweringObjectFileCOFF::lowerRelativeReference`, so that all COFF targets get this.

Also, do you think you'll need to do the same for `getSectionForConstant`?


Repository:
  rL LLVM

https://reviews.llvm.org/D47783