[PATCH] D47736: AMDHSA Code Object v3 assembler syntax update

[Scott Linder via Phabricator via llvm-commits]

scott.linder added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:243-246
+  OS << "\t\t.amdhsa_user_sgpr_dispatch_id "
+     << AMDHSA_BITS_GET(KD.kernel_code_properties,
+                        amdhsa::KERNEL_CODE_PROPERTY_ENABLE_SGPR_DISPATCH_ID)
+     << '\n';
----------------
arsenm wrote:
> Can we start omitting entries when they are the default value? One thing that's been bothering me for a while is how much junk always printed out
I think that is reasonable, the only caveat being that you might see fewer directives coming out than you explicitly provided (if you specify a default value explicitly). I will enumerate the directives and their default values somewhere and change this to only emit required and non-default values.


Repository:
  rL LLVM

https://reviews.llvm.org/D47736