[PATCH] D47725: [SelectionDAG] Provide default expansion for rotates

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz marked 4 inline comments as done.
kparzysz added inline comments.


================
Comment at: lib/Target/Hexagon/HexagonISelLowering.cpp:2100
+HexagonTargetLowering::LowerROTL(SDValue Op, SelectionDAG &DAG) const {
+  if (isa<ConstantSDNode>(Op.getOperand(1).getNode()))
+    return Op;
----------------
RKSimon wrote:
> I don't think you need the getNode() here
I try to keep the SDValue->SDNode conversions explicit in general.


Repository:
  rL LLVM

https://reviews.llvm.org/D47725