[PATCH] D46602: [clang-tidy] Store checks profiling info as JSON files

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: clang-tidy/ClangTidyProfiling.cpp:47
 
+void ClangTidyProfiling::printAsJSON(llvm::raw_ostream &OS) {
+  OS << "{\n";
----------------
aaron.ballman wrote:
> I'm not keen that we call this `printAsJSON()` when the docs talk about writing out YAML. While all JSON is valid YAML, that feels like trivia we shouldn't encode in the function name. What do you think to renaming to `printAsYAML()` instead?
But the actual printer is called `TG->printJSONValues()`..
Let's go the other way around, and canonicalize to JSON.


Repository:
  rL LLVM

https://reviews.llvm.org/D46602