[PATCH] D46866: [EarlyCSE] Avoid a poorly defined instruction comparison

[Jeremy Morse via Phabricator via llvm-commits]

jmorse updated this revision to Diff 149927.
jmorse added a comment.

Rebase on top of r332865:

  https://reviews.llvm.org/rL332865

matchSelectPattern now canonicalises operand order itself: for this patch lines 168-173 take that into account by not trying to order them. Equality and hashing functions are unchanged (which is desirable), tests pass.

Also pseudo-ping: it's not clear to me whether one LGTM overrides another persons earlier needs-review, but the phab interface seems to think so. (My phab-foo is new).


https://reviews.llvm.org/D46866

Files:
  lib/Transforms/Scalar/EarlyCSE.cpp
  test/Transforms/EarlyCSE/sameoperand-cmp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46866.149927.patch
Type: text/x-patch
Size: 44596 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180605/96bb9135/attachment.bin>