[PATCH] D47695: [XRay][compiler-rt] Remove reliance on C++ ABI from BufferQueue

Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 18:39:43 PDT 2018


kpw accepted this revision.
kpw added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/xray/xray_buffer_queue.cc:33
+
+static void **initOwnedBuffers(size_t N) {
+  auto A = reinterpret_cast<void **>(
----------------
Can you template the array init and still be ABI compliant? Other than initialization, these are identical other than the type and that could be traited.

If you can't or feel that would be less readable, feel free to resolve this comment.


https://reviews.llvm.org/D47695





More information about the llvm-commits mailing list