[PATCH] D45604: Support for multiarch runtimes layout

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 18:24:37 PDT 2018


phosek added inline comments.


================
Comment at: compiler-rt/cmake/base-config-ix.cmake:72
 endif()
-set(COMPILER_RT_LIBRARY_OUTPUT_DIR
-  ${COMPILER_RT_OUTPUT_DIR}/lib/${COMPILER_RT_OS_DIR})
-set(COMPILER_RT_LIBRARY_INSTALL_DIR
-  ${COMPILER_RT_INSTALL_PATH}/lib/${COMPILER_RT_OS_DIR})
+if(ENABLE_PER_TARGET_RUNTIME_DIR)
+  set(COMPILER_RT_LIBRARY_OUTPUT_DIR
----------------
rnk wrote:
> Does this usage still work in a standalone compiler-rt build? I'd expect it might warn about using an undefined variable. You might need to duplicate the option into each top-level cmake and do some ugly `if (NOT DEFINED )` hacks, or use some of the existing "if standalone" checks.
Yes, this expression is evaluated as "True if given a variable that is defined to a value that is not a false constant. False otherwise." I checked the standalone build and it's working as before.


Repository:
  rL LLVM

https://reviews.llvm.org/D45604





More information about the llvm-commits mailing list