[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 16:15:18 PDT 2018


morehouse added inline comments.


================
Comment at: tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp:23
 
 #include <cstring>
 
----------------
I think `cstring` is no longer used after this change.  So we can probably remove this include.


================
Comment at: tools/clang-fuzzer/fuzzer-initialize/CMakeLists.txt:3
+
+add_clang_library(clangFuzzerInit fuzzer_initialize.cpp)
----------------
Nit:  `clangFuzzerInitialize` would better follow the naming convention of the other libraries.


================
Comment at: tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.h:15
+
+#include "src/libfuzzer/libfuzzer_macro.h"
+
----------------
I don't think this include is used in this file either.  Can we remove it?


Repository:
  rC Clang

https://reviews.llvm.org/D47666





More information about the llvm-commits mailing list