[PATCH] D47745: Simplified WebAssemblyAsmBackend by removing explicit ELF variant.

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel added inline comments.


================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyAsmBackend.cpp:125
+  return IsELF ? createWebAssemblyELFObjectWriter(OS, Is64Bit, 0)
+               : createWebAssemblyWasmObjectWriter(OS, Is64Bit);
 }
----------------
dschuff wrote:
> sbc100 wrote:
> > IIRC we could probably abort here in the elf case as I think ELF is only used to produce .s format files, not object files.
> > 
> > I guess that might be a separate/larger change so this LGTM as is keep the change small.
> Yeah we should be able to remove the ELF object writer too.
Yes, I was going to fix ELF behavior until Derek pointed out the uselessness of that. So this commit just simplifies code.


Repository:
  rL LLVM

https://reviews.llvm.org/D47745