[PATCH] D47745: Simplified WebAssemblyAsmBackend by removing explicit ELF variant.
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 4 15:15:54 PDT 2018
sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyAsmBackend.cpp:125
+ return IsELF ? createWebAssemblyELFObjectWriter(OS, Is64Bit, 0)
+ : createWebAssemblyWasmObjectWriter(OS, Is64Bit);
}
----------------
IIRC we could probably abort here in the elf case as I think ELF is only used to produce .s format files, not object files.
I guess that might be a separate/larger change so this LGTM as is keep the change small.
Repository:
rL LLVM
https://reviews.llvm.org/D47745
More information about the llvm-commits
mailing list