[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: tools/clang-fuzzer/CMakeLists.txt:48
     ExampleClangProtoFuzzer.cpp
+    FuzzerInitialize.cpp
     )
----------------
Rather than compiling `FuzzerInitialize.cpp` into the binary, can we make it a library like `handle-cxx` or `proto-to-cxx`?


================
Comment at: tools/clang-fuzzer/FuzzerInitialize.cpp:17
 
 #include "cxx_proto.pb.h"
 
----------------
Do we need this include?


================
Comment at: tools/clang-fuzzer/FuzzerInitialize.h:20
+
+#include <cstring>
+
----------------
Why do we need these includes in the header?  Doesn't look like they're used here.


Repository:
  rC Clang

https://reviews.llvm.org/D47666