[PATCH] D47339: [GVN,NewGVN] Propagate nonnull if K dominates J.

[Nuno Lopes via Phabricator via llvm-commits]

nlopes added inline comments.


================
Comment at: test/Transforms/NewGVN/metadata-nonnull.ll:45
+; CHECK:       bb1:
+; CHECK-NEXT:    ret i8* [[V1]]
+; CHECK:       bb2:
----------------
This doesn't seem correct to be in the model where load !nonnull is not UB. Passing poison as a function argument is not UB. The function might not even use the argument, for example.
Anyway, we need to define the semantics !nonnull before moving on, otherwise we can't tell if this is correct or not.



https://reviews.llvm.org/D47339