[PATCH] D47399: Add _LIBCPP_LARGE_CODEBASE

Eric Fiselier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 11:36:30 PDT 2018


EricWF added inline comments.


================
Comment at: include/string:798
     basic_string(size_type __n, _CharT __c, const _Allocator& __a);
+    _LIBCPP_TWEAK_NEVER_INLINE
     basic_string(const basic_string& __str, size_type __pos, size_type __n,
----------------
Most of these functions *can't* be inlined by the compiler unless the `inline` keyword is explicitly specified because these functions are externally instantiated.

I suspect not only that these functions not need `__attribute__((noinline))` but that would implicitly have that effect if `__attribute__((always_inline))` was omitted.


https://reviews.llvm.org/D47399





More information about the llvm-commits mailing list