[PATCH] D47688: [Support] Add functions that return native file handles on Windows instead of fds.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 10:40:38 PDT 2018


rnk added a comment.

We discussed this in person, and I think the best way forward is to use this new typedef everywhere in all code. As a migration path, I think it would be best to rename the existing integer FD APIs to `openFileDescriptorForRead/Write`. Then we can add back `openFileForRead` and have it return the new handle / FD wrapper typedef. The new typedef be called `file_t` so we don't have to use the word "native" everywhere and we can just talk about "files".


https://reviews.llvm.org/D47688





More information about the llvm-commits mailing list