[PATCH] D47653: [lit, pdb] Fix two failing PDB tests on Windows

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In https://reviews.llvm.org/D47653#1121141, @stella.stamenova wrote:

> In https://reviews.llvm.org/D47653#1120508, @labath wrote:
>
> > > newer DIA SDKs annotate the function names with their return type and inputs
> >
> > Does this mean that the tests will now fail for people who happen to have older/different versions of MSVS/DIA SDK installed?
>
>
> It should not fail for people with newer versions because I updated the matching pattern to include both.
>
> One thing I did notice, though, is that the order in which some of the symbol sections are generated differs but FileCheck looks for matches in the order in the test file. Do you know of a way to make it match either order? Right now the section for FuncSymbols.cpp is sometimes before and sometimes after the section for FuncSymbolsTestMain.cpp


Can you give a concrete example?  `CHECK-DAG` should work with any order.  If you mean that the order of the files themselves are different, then yea I could see that being a problem.  In that case you'd need multiple filecheck lines, one for each file.  This way it would run the command multiple times but each time only match the output of a single file.


Repository:
  rL LLVM

https://reviews.llvm.org/D47653