[PATCH] D47703: [Mips] Remove uneeded variants of ADDC/ADDE lowering

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix added inline comments.


================
Comment at: lib/Target/Mips/MipsSEISelLowering.cpp:85
 
   if (Subtarget.hasDSP()) {
     MVT::SimpleValueType VecTys[2] = {MVT::v2i16, MVT::v4i8};
----------------
Here.


================
Comment at: lib/Target/Mips/MipsSEISelLowering.cpp:108
+
+    if (Subtarget.hasMips32r2()) {
+      setOperationAction(ISD::ADDC, MVT::i32, Legal);
----------------
sdardis wrote:
> This needs to be Subtarget.hasDSP() && Subtarget.hasMips32r2().
This is what it is doing, see the if around the whole section.


Repository:
  rL LLVM

https://reviews.llvm.org/D47703