[PATCH] D47428: [InstCombine] PR37603: low bit mask canonicalization
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 4 07:05:19 PDT 2018
lebedev.ri added a comment.
In https://reviews.llvm.org/D47428#1120886, @spatel wrote:
> In https://reviews.llvm.org/D47428#1120867, @lebedev.ri wrote:
>
> > I was just thinking about profitability of transform to `xor %x, -1`,
> > and thought whether we could always do that if the input is `add %x, -1`.
> >
> > I can submit that fold as a follow-up.
>
>
> Sounds good. This patch LGTM.
Thank you for the review!
To not degrade x86 backend, this can't land until after https://reviews.llvm.org/D47453.
Repository:
rL LLVM
https://reviews.llvm.org/D47428
More information about the llvm-commits
mailing list