[PATCH] D47428: [InstCombine] PR37603: low bit mask canonicalization

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri updated this revision to Diff 149752.
lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.

Address review notes.

In https://reviews.llvm.org/D47428#1120820, @spatel wrote:

> We didn't resolve the 'nuw' question - am I not seeing the scenario that you asked about?


True.
It was just a passing-by thought.
Here i don't particularly care about that fold.
I was just thinking about profitability of transform to `xor %x, -1`,
and thought whether we could always do that if the input is `add %x, -1`.

I can submit that fold as a follow-up.


Repository:
  rL LLVM

https://reviews.llvm.org/D47428

Files:
  lib/Transforms/InstCombine/InstCombineAddSub.cpp
  test/Transforms/InstCombine/rem.ll
  test/Transforms/InstCombine/set-lowbits-mask-canonicalize.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47428.149752.patch
Type: text/x-patch
Size: 10229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180604/f501ed82/attachment.bin>