[PATCH] D47595: [VPlan] Move recipe construction to VPRecipeBuilder.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Will do, thanks for having a look Diego!



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:6481
 
-bool LoopVectorizationPlanner::getDecisionAndClampRange(
+bool VPRecipeBuilder::getDecisionAndClampRange(
     const std::function<bool(unsigned)> &Predicate, VFRange &Range) {
----------------
dcaballe wrote:
> fhahn wrote:
> > dcaballe wrote:
> > > Not a big deal but I wonder if it would be better to move this outside of VPRecipeBuilder since it's not strictly creating or manipulating any recipe and it will be needed eventually in the VPlan native path.
> > Yep I think it would be better to move it somewhere else. I've moved it back to a static method in LoopVectorizationPlanner. Do you think there's a better place?
> I think it's OK for now. We already have a VPBlockUtils and I envision a VPInstructionUtils. We should also have something similar for more generic stuff but we can introduce it when we have a clearer picture of it.
Yep I think that will be helpful in the future.


https://reviews.llvm.org/D47595