[PATCH] D47639: [llvm-exegesis] Analysis: Show inconsistencies between checked-in and measured data.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 02:20:17 PDT 2018


courbet marked an inline comment as done.
courbet added a comment.

Thanks PTAL.



================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:314
+    ClusterCenterPoint[0].Value = Representative[0].avg();
+    SchedClassPoint[0].Value = 0.0; // FIXME: implement latency.
+  } else if (Mode == "uops") {
----------------
gchatelet wrote:
> I would just return an error here and not let the user think the tool ran correctly.
Even better: implement it ! :)


Repository:
  rL LLVM

https://reviews.llvm.org/D47639





More information about the llvm-commits mailing list