[PATCH] D47692: [LLDB] Unit tests basic support for OpenBSD

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 01:25:29 PDT 2018


labath added inline comments.


================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1429-1448
+        elif sys.platform.rstrip('0123456789') in ('freebsd', 'linux', 'netbsd', 'openbsd', 'darwin') or os.environ.get('LLDB_BUILD_TYPE') == 'Makefile':
             d = {
                 'CXX_SOURCES': sources,
                 'EXE': exe_name,
                 'CFLAGS_EXTRAS': "%s %s -I%s" % (stdflag,
                                                  stdlibflag,
                                                  os.path.join(
----------------
How about we move the windows branch up, and replace this ever-growing list of platforms with a simple "else" clause? (Same for the buildLibrary function below.)


Repository:
  rL LLVM

https://reviews.llvm.org/D47692





More information about the llvm-commits mailing list