[PATCH] D47624: [SimpleLoopUnswitch] Invalidate SCEV after making structural changes to a loop
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 3 18:50:55 PDT 2018
mkazantsev added inline comments.
================
Comment at: lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:2015
+ // invariants in SCEV for this and any outer loop.
+ // FIXME: Is it OK that unswitching produces invalid loops?!
+ if (Changed && !L->isInvalid())
----------------
chandlerc wrote:
> Definitely isn't. Feel free to make the FIXME more explicit. Also, do you have a minimal test case? Good to put that in a PR.
It fails 2 existing unit tests, I will add them into the comment.
https://reviews.llvm.org/D47624
More information about the llvm-commits
mailing list