[PATCH] D47452: [NFC][X86][AArch64] Reorganize/cleanup BZHI test patterns

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

The bmi.ll file is a mess of intrinsics and general combine/pattern tests (which is understandable given so few of the bmi ops are actually inplemented as intrinsics in the headers).

Please can you limit your changes to bmi.ll to pulling out the bzhi tests and I'll work on cleaning up the rest of the file like I did for bmi2



================
Comment at: test/CodeGen/X86/extract-lowbits.ll:12
+; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+bmi,-tbm,+bmi2 < %s | FileCheck %s --check-prefixes=CHECK,X64,BMI1,X64-BMI1,BMI1BMI2,X64-BMI1BMI2,BMI1NOTBMBMI2,X64-BMI1NOTBMBMI2
+
+; *Please* keep in sync with test/CodeGen/AArch64/extract-lowbits.ll
----------------
Given bzhi is a bmi2 op I see very little benefit from testing it on bmi1/tbm only targets, what does it look like if you limit this to 'plain' X86/X64 and BMI2 X86/X64 test?

Also, you don't appear to have left in all the generated code from the update script.




Repository:
  rL LLVM

https://reviews.llvm.org/D47452