[PATCH] D47651: [lit, lldbmi] Skip the new break-insert test on Windows

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

There are a couple of things to address:

1. The fact that the test won't exit because lldb-mi won't exit. This happens especially when there's an issue when the test executes. For example, if I run just the lldb-mi test from the test (when the executable doesn't exist), it fails but then doesn't quit. This is the same behavior as when the test fails.

  c:\agent1\_work\82\b>C:\agent1\_work\82\b\release\bin\lldb-mi.EXE --synchronous < C:\agent1\_work\82\s\llvm\tools\lldb\lit\tools\lldb-mi\breakpoint\break-insert.test
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0xffffffffffffffff",func="??",file="??",fullname="??/??",line="0",pending=["breakpoint"],times="0",original-location="breakpoint"}
  (gdb)
  =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0xffffffffffffffff",func="??",file="??",fullname="??/??",line="0",pending=["breakpoint"],times="0",original-location="breakpoint"}
  (gdb)
  ^done
  (gdb)
  ^error,msg="Command 'file-exec-and-symbols'. Target binary 'C:\agent1\_work\82\b\tools\lldb\lit\tools\lldb-mi\breakpoint\a.out' is invalid. error: unable to find executable for 'C:\agent1\_work\82\b\tools\lldb\lit\tools\lldb-mi\breakpoint\a.out'"
  (gdb)
  ^done
  (gdb)



2. The failure itself. The test expects that the breakpoint that is set will be hit, but it is not and the program exits normally:

  c:\agent1\_work\82\b>C:\agent1\_work\82\b\release\bin\lldb-mi.EXE --synchronous < C:\agent1\_work\82\s\llvm\tools\lldb\lit\tools\lldb-mi\breakpoint\break-insert.test
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0xffffffffffffffff",func="??",file="??",fullname="??/??",line="0",pending=["breakpoint"],times="0",original-location="breakpoint"}
  (gdb)
  =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0xffffffffffffffff",func="??",file="??",fullname="??/??",line="0",pending=["breakpoint"],times="0",original-location="breakpoint"}
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  =library-loaded,id="C:\\agent1\\_work\\82\\b\\tools\\lldb\\lit\\tools\\lldb-mi\\breakpoint\\a.exe",target-name="C:\\agent1\\_work\\82\\b\\tools\\lldb\\lit\\tools\\lldb-mi\\breakpoint\\a.exe",host-name="C:\\agent1\\_work\\82\\b\\tools\\lldb\\lit\\tools\\lldb-mi\\breakpoint\\a.exe",symbols-loaded="0",loaded_addr="-",size="0"
  =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="keep",enabled="y",addr="0xffffffffffffffff",func="??",file="??",fullname="??/??",line="0",pending=["breakpoint"],times="0",original-location="breakpoint"}
  (gdb)
  ^done
  (gdb)
  ^running
  =thread-group-started,id="i1",pid="18472"
  (gdb)
  =thread-created,id="1",group-id="i1"
  =thread-selected,id="1"
  (gdb)
  =library-loaded,id="C:\\agent1\\_work\\82\\b\\tools\\lldb\\lit\\tools\\lldb-mi\\breakpoint\\a.exe",target-name="C:\\agent1\\_work\\82\\b\\tools\\lldb\\lit\\tools\\lldb-mi\\breakpoint\\a.exe",host-name="C:\\agent1\\_work\\82\\b\\tools\\lldb\\lit\\tools\\lldb-mi\\breakpoint\\a.exe",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\ntdll.dll",target-name="C:\\Windows\\System32\\ntdll.dll",host-name="C:\\Windows\\System32\\ntdll.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\ntdll.dll",target-name="C:\\Windows\\System32\\ntdll.dll",host-name="C:\\Windows\\System32\\ntdll.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\kernel32.dll",target-name="C:\\Windows\\System32\\kernel32.dll",host-name="C:\\Windows\\System32\\kernel32.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\kernel32.dll",target-name="C:\\Windows\\System32\\kernel32.dll",host-name="C:\\Windows\\System32\\kernel32.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\KernelBase.dll",target-name="C:\\Windows\\System32\\KernelBase.dll",host-name="C:\\Windows\\System32\\KernelBase.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\KernelBase.dll",target-name="C:\\Windows\\System32\\KernelBase.dll",host-name="C:\\Windows\\System32\\KernelBase.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\apphelp.dll",target-name="C:\\Windows\\System32\\apphelp.dll",host-name="C:\\Windows\\System32\\apphelp.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\apphelp.dll",target-name="C:\\Windows\\System32\\apphelp.dll",host-name="C:\\Windows\\System32\\apphelp.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\kernel.appcore.dll",target-name="C:\\Windows\\System32\\kernel.appcore.dll",host-name="C:\\Windows\\System32\\kernel.appcore.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\kernel.appcore.dll",target-name="C:\\Windows\\System32\\kernel.appcore.dll",host-name="C:\\Windows\\System32\\kernel.appcore.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\msvcrt.dll",target-name="C:\\Windows\\System32\\msvcrt.dll",host-name="C:\\Windows\\System32\\msvcrt.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\msvcrt.dll",target-name="C:\\Windows\\System32\\msvcrt.dll",host-name="C:\\Windows\\System32\\msvcrt.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\rpcrt4.dll",target-name="C:\\Windows\\System32\\rpcrt4.dll",host-name="C:\\Windows\\System32\\rpcrt4.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="C:\\Windows\\System32\\rpcrt4.dll",target-name="C:\\Windows\\System32\\rpcrt4.dll",host-name="C:\\Windows\\System32\\rpcrt4.dll",symbols-loaded="0",loaded_addr="-",size="0"
  (gdb)
  =library-unloaded,id="C:\\agent1\\_work\\82\\b\\tools\\lldb\\lit\\tools\\lldb-mi\\breakpoint\\a.exe",target-name="C:\\agent1\\_work\\82\\b\\tools\\lldb\\lit\\tools\\lldb-mi\\breakpoint\\a.exe",host-name="C:\\agent1\\_work\\82\\b\\tools\\lldb\\lit\\tools\\lldb-mi\\breakpoint\\a.exe"
  (gdb)
  =thread-exited,id="1",group-id="i1"
  =thread-group-exited,id="i1",exit-code="0"
  *stopped,reason="exited-normally"
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)


Repository:
  rL LLVM

https://reviews.llvm.org/D47651