[PATCH] D47662: Move some function declarations out of WindowsSupport.h

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 15:18:53 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/include/llvm/Support/ConvertUTF.h:292
+namespace windows {
+std::error_code UTF8ToUTF16(StringRef utf8, SmallVectorImpl<wchar_t> &utf16);
+/// Convert to UTF16 from the current code page used in the system
----------------
I guess these are win32 only because wchar_t is unlikely to be the right type on other systems with 32-bit wchars. Sounds good.


https://reviews.llvm.org/D47662





More information about the llvm-commits mailing list