[PATCH] D47604: [Polly] Add isl C++ list iterators

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 14:55:55 PDT 2018


Meinersbur added a comment.

[serious] Could you document what you expect to happen in out-of-quote situations? I just noticed that eg. `USet.get_set_list` will allocate a new list, thus may fail in `IslQuotaScope`s.

I am a bit concerned about allocating a heavy-weight heap object just for iterating over something. That is, the iterators over list object are great, but in the long term maybe we could find a way to avoid creating such lists to iterate over sets/maps.


Repository:
  rPLO Polly

https://reviews.llvm.org/D47604





More information about the llvm-commits mailing list