[PATCH] D47648: ELF: Don't query a shared symbol's alignment unless necessary.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 13:37:53 PDT 2018


ruiu added a comment.

That's true that a shared symbol can refer an underlying ELF data structure using VerdefIndex, but that's I believe optional. You can leave it out with the default value to represent "no version". For ELFSym, it is mandatory, and we are not doing that in other places, so I'm inclined to not do this.


https://reviews.llvm.org/D47648





More information about the llvm-commits mailing list