[PATCH] D47648: ELF: Don't query a shared symbol's alignment unless necessary.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 13:17:40 PDT 2018


ruiu added a comment.

This patch itself looks decent, but I think the principle here is to avoid referring ELF-file data structures directly from Symbol to reduce dependency between Symbol and the underlying ELF files. Previously, we store a pointer to ELFSym to each Symbol, and at some point we rewrote to eliminate that. That makes it easy to create a fake Shared symbol too.


https://reviews.llvm.org/D47648





More information about the llvm-commits mailing list