[PATCH] D47615: [DebugInfo] Adding DISubprogram::setFlags identical to DIType::setFlags

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 10:57:37 PDT 2018

Previous message: [PATCH] D47615: [DebugInfo] Adding DISubprogram::setFlags identical to DIType::setFlags
Next message: [PATCH] D47615: [DebugInfo] Refactoring DIType::setFlags to DIType::cloneWithFlags
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

aprantl added a comment.

> toughen the assertion to isTemporary instead of just !isUniqued and mirror the methods for DISubprogram, or

I like that.

> 2 and 3 also work for me. It's more work to implement but it seems even cleaner.


Repository:
  rL LLVM

https://reviews.llvm.org/D47615

Previous message: [PATCH] D47615: [DebugInfo] Adding DISubprogram::setFlags identical to DIType::setFlags
Next message: [PATCH] D47615: [DebugInfo] Refactoring DIType::setFlags to DIType::cloneWithFlags
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list