[PATCH] D47595: [VPlan] Move recipe construction to VPRecipeBuilder.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 08:56:50 PDT 2018


fhahn added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:6481
 
-bool LoopVectorizationPlanner::getDecisionAndClampRange(
+bool VPRecipeBuilder::getDecisionAndClampRange(
     const std::function<bool(unsigned)> &Predicate, VFRange &Range) {
----------------
dcaballe wrote:
> Not a big deal but I wonder if it would be better to move this outside of VPRecipeBuilder since it's not strictly creating or manipulating any recipe and it will be needed eventually in the VPlan native path.
Yep I think it would be better to move it somewhere else. I've moved it back to a static method in LoopVectorizationPlanner. Do you think there's a better place?


https://reviews.llvm.org/D47595





More information about the llvm-commits mailing list