[PATCH] D47517: [AArch64][SVE] Asm: Support for CPY immediate instructions
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 1 08:34:31 PDT 2018
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/Target/AArch64/SVEInstrFormats.td:625
+class sve_int_dup_imm_pred<bits<2> sz8_64, bit m, string asm,
+ ZPRRegOp zprty,
+ string pred_qual, dag iops>
----------------
nit: could this go on the previous line?
================
Comment at: lib/Target/AArch64/SVEInstrFormats.td:628
+: I<(outs zprty:$Zd), iops,
+ asm, "\t$Zd, $Pg"#pred_qual#", $imm",
+ "",
----------------
nit: could those go in the previous line? I realize that we have a similar formatting at other places but do we need the newlines here?
https://reviews.llvm.org/D47517
More information about the llvm-commits
mailing list