[PATCH] D46379: [ConstantFold] Turn off expression simplification for vector type

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 07:08:11 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D46379#1118803, @Ka-Ka wrote:

> Do you think I should still include the negative testcase that you specified above even if the patch now only affect the GEP case?


Yes - because the earlier revision would have caused a bug with no regression test coverage for it. Let's add that to be safe. Also, I'd prefer to use the utils/update_test_checks.py script on all tests because it makes maintenance easier. And as before, if you check in the baseline version of the test using trunk output, that's even better - we want to keep the tests in place even if the patch gets reverted for some reason.


Repository:
  rL LLVM

https://reviews.llvm.org/D46379





More information about the llvm-commits mailing list