[PATCH] D47590: DWARFAcceleratorTable: Add an iterator-based api for accessing names in the index

[Pavel Labath via Phabricator via llvm-commits]

labath added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:376
+    /// string offset is not valid.
+    const char *getString() const {
+      uint32_t Off = StringOffset;
----------------
JDevlieghere wrote:
> Have you considered wrapping this in a StringRef?
Yes. My reasoning for not doing that is that it allows you to distinguish between the "string not found" and "empty string" cases. Though I could be easily convinced to add a StringRef version for users which don't care about the distinction.


Repository:
  rL LLVM

https://reviews.llvm.org/D47590