[PATCH] D47482: [AArch64][SVE] Asm: Support for FDUP_ZI (copy fp immediate) instruction.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 02:35:52 PDT 2018


sdesmalen added a comment.

I think the difference with other immediates that have a limited set, is that these immediates have a non-trivial parsing/decoding/printing. Rather than just allowing a given range of integer values the string is first parsed as FP value and then encoded as integer value between 0-255. And the opposite for the decode. I think it makes sense to test these cases individually, although I can see how doing this for the FMOV alias as well could be a bit excessive, so I'll reduce those.

The assembler/disassembler tests are mostly there to test against regression and I don't really expect anyone to check/update the encoding/decoding. This as opposed to the negative-tests, which may be updated to provide more sensible diagnostics.


https://reviews.llvm.org/D47482





More information about the llvm-commits mailing list