[PATCH] D47482: [AArch64][SVE] Asm: Support for FDUP_ZI (copy fp immediate) instruction.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 01:56:14 PDT 2018


sdesmalen added a comment.

In https://reviews.llvm.org/D47482#1118614, @fhahn wrote:

> Looks good, but do the tests have to be that big? That makes it really hard to spot if the edge cases & aliases are handled properly. Can you reduce the size a bit?


Since the immediate encoding only allows for a limited set of 256 different floating-point immediates, I thought it would make sense to test each of them separately to make sure they are all correctly parsed, assembled and printed, since basically these are all the edge-cases. The negative tests are much smaller and test a few floating point values that cannot be encoded. I can easily reduce the tests, but I think these tests are valuable. What do you think?


https://reviews.llvm.org/D47482





More information about the llvm-commits mailing list