[PATCH] D47602: Correct aligment computation for shared object symbols

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 31 14:39:25 PDT 2018


pcc added a comment.

In https://reviews.llvm.org/D47602#1118200, @shenhan wrote:

> Thanks @ruiu .
>
> @pcc do you agree with initializing Ret to uint64-1?


Sounds good. Even in the case where the virtual address is intentionally 0, we would still want to use the `sh_addralign` alignment.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47602





More information about the llvm-commits mailing list