[PATCH] D47477: [VPlan] Move recipe based VPlan generation to separate function.

[Diego Caballero via Phabricator via llvm-commits]

dcaballe added a comment.

Thanks for revisiting this, Florian!
No major issues. Just one question below.

Thanks,
Diego



================
Comment at: lib/Transforms/Vectorize/LoopVectorizationPlanner.h:357
+  /// Build VPlans for power-of-2 VF's between \p MinVF and \p MaxVF inclusive,
+  /// according to the information gathered by Legal when it checked ijf it is
+  /// legal to vectorize the loop. This method creates VPlans using VPRecipes.
----------------
ijf -> if


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:6341
 
+  buildVPlansWithVPRecipes(1, MaxVF);
+  LLVM_DEBUG(printPlans(dbgs()));
----------------
Just wondering if `buildVPlans` happened before the if condition for some reason. Is it possible that we still need the VF=1 VPlan for interleaving? Not sure if there is a test covering this case. Could you please have a look? If should be easy to test using #pragma clang loop interleave.


https://reviews.llvm.org/D47477