[PATCH] D47581: [LNT] Fix use of field index in daily report

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.

Hi John,

Thanks for fixing this!
Ideally, there should also be a check added to the LNT unit tests (e.g. somewhere near https://github.com/llvm-mirror/lnt/blob/master/tests/server/ui/V4Pages.py#L433).
At the moment, the "check_table_content" function there only checks text in tables, not anything in HTML tags, IIRC. (see function get_table_body_content for where everything inside HTML tags is filtered out, https://github.com/llvm-mirror/lnt/blob/master/tests/server/ui/V4Pages.py#L178).
Maybe the best way to test this is to add a helper function in tests/server/ui/V4Pages.py to extract the full content from a specific field from the table (i.e. including all HTML tags) and check against exact HTML content?

What do you think - would that be feasible and useful to implement?


Repository:
  rL LLVM

https://reviews.llvm.org/D47581