[PATCH] D47511: [AMDGPU] Construct memory clauses before RA

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 30 23:58:49 PDT 2018


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFormMemoryClauses.cpp:242
+  RPT.advanceToNext();
+  GCNRegPressure MaxPressure = RPT.moveMaxPressure();
+  unsigned Occupancy = MaxPressure.getOccupancy(*ST);
----------------
vpykhtin wrote:
> moveMaxPressure actually clears accumulated MaxPressure - is this intended?
That is the only interface we made here ;) It does not really matter, as the next step will recreate MaxPressure. Take in mind that pressure cannot go down within the clause, only after. Therefor CurPressure is always a MaxPressure too while inside the clause.


https://reviews.llvm.org/D47511





More information about the llvm-commits mailing list