[PATCH] D47509: [AMDGPU] Track occupancy in MFI

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:185
+  const SISubtarget& ST = MF.getSubtarget<SISubtarget>();
+  limitOccupancy(ST.getOccupancyWithLocalMemSize(getLDSSize(),
+                 MF.getFunction()));
----------------
vpykhtin wrote:
> may be one call to limitOccupancy with min(getMaxWavesPerEU and getOcc..LMS)?
It is really the same, it will even produce the same code after compilation. The whole intent of "limit" semantics is that you can take into account just a single factor and omit all others. I would prefer to keep this snippet to emphasize that ;)


https://reviews.llvm.org/D47509