[PATCH] D47511: [AMDGPU] Construct memory clauses before RA

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstructions.td:548-550
+def SI_MEMORY_CLAUSE : SPseudoInstSI <
+  (outs), (ins variable_ops)
+>;
----------------
rampitec wrote:
> arsenm wrote:
> > Why do you use this instead of using the generic TargetOpcode::BUNDLE?
> > I think trying to use a custom bundle instruction is going to cause issues. For example instruction size computation for this won't work properly, and any other code that expects to see BUNDLE
> Primarily to know what to remove post-RA. I do not think it creates any problems though, for instance getFunctionCodeSize() is called when memory clauses are already unbundled.
Actually I can do it with BUNDLE too. Resulting bundle returns mayLoad() and can be identified.


https://reviews.llvm.org/D47511