[PATCH] D47540: [lld] Enable Visual Studio compatible output

[ben via Phabricator via llvm-commits]

bd1976llvm added a comment.

Hi Rui! Thanks for looking at the patch.

Chris is ill so I am replying instead.

In https://reviews.llvm.org/D47540#1116447, @ruiu wrote:

> I reviewed this patch, but I'm not convinced that we really want this. You are changing the ELF linker, but how many people are using our ELF linker on Visual Studio?


Surprisingly many! Wikipedia currently lists 1765 <https://en.wikipedia.org/wiki/List_of_PlayStation_4_games> planned or released PlayStation(R) 4 games, each of which was built with our elf toolchain.

In https://reviews.llvm.org/D47540#1116447, @ruiu wrote:

> Did you try to talk with Microsoft to let them make a change for you instead of making a change to us? I'm not trying to reject this, but adding a new feature and a new command line flag always needs a fairly strong justification, so please explain how much useful this is.


Visual Studio's diagnostic message format is mature and well documented, so although we can propose a change, it seems unlikely that microsoft will implement a change in the near future.

It looks like Chris' patch could be adapted for COFF lld too, with a few changes. Do you think that would be useful?


https://reviews.llvm.org/D47540