[PATCH] D47523: [X86] Extract latency of fldz/fld1 in separate classes.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with 2 minors



================
Comment at: lib/Target/X86/X86InstrFPStack.td:569
 def LD_F0 : FPI<0xD9, MRM_EE, (outs), (ins), "fldz">;
+} // SchedRW
+
----------------
Drop the braces for single entries like this


================
Comment at: lib/Target/X86/X86Schedule.td:146
+def  WriteF80Constant0  : SchedWrite;
+def  WriteF80Constant1  : SchedWrite;
 def  WriteFLoadX        : SchedWrite;
----------------
courbet wrote:
> RKSimon wrote:
> > Shorten the names to WriteFLD0, WriteFLD1, - allows you to remove all the indentation changes.
> > 
> > Please add WriteFLDC for the other math constants (FLDPI etc.)
> > Shorten the names to WriteFLD0, WriteFLD1, - allows you to remove all the indentation changes.
> 
> Done.
> 
> > Please add WriteFLDC for the other math constants (FLDPI etc.)
> 
> If you don't mind I'll tacle this one in a separate diff.
Really pedantic but please could you put these new entries above WriteFLoad so all the WriteFLoad* tags are together.


Repository:
  rL LLVM

https://reviews.llvm.org/D47523