[PATCH] D47328: [AArch64][SVE] Asm: Support for DUPM (masked immediate) instruction.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp:1495
+  // Prefer the default format for 16bit values, hex otherwise.
+  if ((int16_t)PrintVal == (SignedT)PrintVal)
+    printImmSVE((T)PrintVal, O);
----------------
If was wondering if this could be simplified to:

  if (std::is_same<T, int16_t>::value) 
    printImmSVE(PrintVal, O);
  else 
    O << '#' << formatHex((uint64_t)PrintVal);


================
Comment at: test/MC/AArch64/SVE/mov.s:185
+mov     z0.h, #32768
+// CHECK-INST: dupm    z0.h, #0x8000
+// CHECK-ENCODING: [0x00,0x0c,0xc0,0x05]
----------------
just checking: do we expect dupm here?


https://reviews.llvm.org/D47328