[PATCH] D47550: [Power9] Add __float128 builtins for Round To Odd

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 31 01:51:49 PDT 2018


nemanjai added a comment.

Other than the formatting issues that Lei identified (and some issues with commas that separate operands not being followed by spaces), this seems fine to me. However, a couple of suggestions:

- Find a reviewer for the target-independent stuff (perhaps from CODE_OWNERS.txt).
- Add a note in the patch description about any documentation of these builtins from GCC and any other compilers
- Actually link the patch dependencies in Phabricator between the clang and LLVM portions


https://reviews.llvm.org/D47550





More information about the llvm-commits mailing list