[PATCH] D47574: [EarlyCSE] Propagate conditions of AND and OR instructions

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 31 01:27:00 PDT 2018


lebedev.ri added inline comments.


================
Comment at: lib/Transforms/Scalar/EarlyCSE.cpp:723
+  auto IsAnd = [](Instruction *I) {
+    if (BinaryOperator *And = dyn_cast<BinaryOperator>(I))
+      return And->getOpcode() == Instruction::And;
----------------
It would be less confusing to name it `BOp`


================
Comment at: lib/Transforms/Scalar/EarlyCSE.cpp:728
+  auto IsOr = [](Instruction *I) {
+    if (BinaryOperator *Or = dyn_cast<BinaryOperator>(I))
+      return Or->getOpcode() == Instruction::Or;
----------------
It would be less confusing to name it `BOp`


https://reviews.llvm.org/D47574





More information about the llvm-commits mailing list