[PATCH] D47414: [llvm-objcopy] Fix null symbol handling

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 31 01:06:47 PDT 2018


jhenderson added a comment.

In https://reviews.llvm.org/D47414#1117184, @jakehehrlich wrote:

> Quick drop in. What I was thinking about before was to just never pass the
>  null symbol to remove or anything else. It can still be there it just
>  shouldn't be allowed to be updated or removed.
>
> As for how the null section header should be treated we have to consider
>  large indexes before proceeding.


Yes, I think this is essentially my suggestion with the change to `removeSymbols` etc.


Repository:
  rL LLVM

https://reviews.llvm.org/D47414





More information about the llvm-commits mailing list